The vast majority of felonies should not be a bar to holding public office. What if you had a felony conviction for possession of weed? Should that bar you from holding office or should you be allowed to run for office to try and change an unjust law?
The only crimes that should bar one from office are the ones that already do under the 14th Amendment, under which Trump should already be ineligible. He swore an oath to defend the Constitution and then participated in a conspiracy to violently overthrow it.